Add data property on the MessageRequestInstance #24
Merged
adrianZahra merged 1 commit intoScalablePixelStreaming:v1.0.0from Mar 22, 2023
Merged
Add data property on the MessageRequestInstance #24adrianZahra merged 1 commit intoScalablePixelStreaming:v1.0.0from
adrianZahra merged 1 commit intoScalablePixelStreaming:v1.0.0from
Conversation
… for sending optional configuration data to the signalling server
adrianZahra
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
There was no
dataproperty on theMessageRequestInstanceto allow an opaque string representing optional configuration data to pass to the signalling server for instance customisationSolution
Added a
datapropertyDocumentation
Test Plan and Compatibility
Confirmed that the data does get sent via the
requestInstancewebsocket